mirror of
https://github.com/computerim/impactflow-discovery.git
synced 2026-08-27 08:30:35 +00:00
Joel Salmon
b9d7b0e22b
Final roadmap phase. No DB migration — it reads data already captured.
- Goal-evolution history: GET /discovery/profile/me/goal-history derives a
per-goal timeline from the profile_revision snapshots (pure aggregator in
app/services/profile_history.py).
- Smart tagging: POST /discovery/integration/suggest-foundation suggests which
foundation a task builds toward + rationale/confidence (FoundationTagger,
app/services/tagging.py). Suggestion only; the person confirms by posting the
task mapping.
- Deeper goal-refinement: the reflect loop accepts an optional focus ("goals")
that steers the coach toward sharpening goals — still mirror, not compass.
- Visualizations: visuals.html renders an Ikigai Venn and an Enneagram diagram
(plain-language callouts, not the raw type number) plus the goal-evolution
timeline; linked from profile.html.
Tests: 99 passing (added pure goal-history tests, goal-history + suggest
endpoint tests, reflect-focus passthrough; run in-container). README updated.
This completes the ImpactFlow Vision roadmap (Phases 1-5) on the Discovery side.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
98 lines
3.5 KiB
Python
98 lines
3.5 KiB
Python
from pathlib import Path
|
|
|
|
|
|
def test_discovery_page_uses_cookie_session_not_user_id():
|
|
"""The browser session is a server-set cookie, so the page must not mint
|
|
or carry a client-side user id, and all calls go through authedFetch."""
|
|
html = Path("app/static/discovery.html").read_text(encoding="utf-8")
|
|
|
|
assert "impactflow_user_id" not in html
|
|
assert "createUserId" not in html
|
|
assert "user_id" not in html
|
|
assert "authedFetch" in html
|
|
assert '/static/auth.js' in html
|
|
|
|
|
|
def test_profile_page_uses_me_endpoints_and_authed_fetch():
|
|
"""Profile reads/confirms via the user-scoped /me routes, authenticated by
|
|
the session cookie through authedFetch — not the old user_id-in-URL paths."""
|
|
html = Path("app/static/profile.html").read_text(encoding="utf-8")
|
|
|
|
assert "/discovery/profile/me" in html
|
|
assert "/discovery/profile/me/confirm" in html
|
|
assert "user_id" not in html
|
|
assert "authedFetch" in html
|
|
|
|
|
|
def test_profile_page_has_edit_affordance():
|
|
"""The read/edit/affirm DoD: an Edit control that PATCHes the profile."""
|
|
html = Path("app/static/profile.html").read_text(encoding="utf-8")
|
|
|
|
assert "renderEdit" in html
|
|
assert 'method: "PATCH"' in html
|
|
assert "Edit my words" in html
|
|
|
|
|
|
def test_reflect_page_uses_reflection_endpoints():
|
|
"""Phase 2 reflection page drives the coach loop via authedFetch."""
|
|
html = Path("app/static/reflect.html").read_text(encoding="utf-8")
|
|
|
|
assert "/discovery/profile/me/reflect" in html
|
|
assert "/discovery/profile/me/reflection" in html
|
|
assert "authedFetch" in html
|
|
assert "user_id" not in html
|
|
|
|
|
|
def test_profile_page_links_to_reflection():
|
|
html = Path("app/static/profile.html").read_text(encoding="utf-8")
|
|
assert "/static/reflect.html" in html
|
|
|
|
|
|
def test_coaching_page_uses_coaching_endpoints():
|
|
"""Phase 3 coaching page drives preferences + check-ins via authedFetch."""
|
|
html = Path("app/static/coaching.html").read_text(encoding="utf-8")
|
|
assert "/discovery/coaching/preferences" in html
|
|
assert "/discovery/coaching/checkins" in html
|
|
assert "authedFetch" in html
|
|
assert "user_id" not in html
|
|
|
|
|
|
def test_profile_page_links_to_coaching():
|
|
html = Path("app/static/profile.html").read_text(encoding="utf-8")
|
|
assert "/static/coaching.html" in html
|
|
|
|
|
|
def test_dashboard_page_uses_work_patterns_endpoint():
|
|
"""Phase 4 dashboard reads work patterns via authedFetch."""
|
|
html = Path("app/static/dashboard.html").read_text(encoding="utf-8")
|
|
assert "/discovery/integration/work-patterns" in html
|
|
assert "authedFetch" in html
|
|
assert "user_id" not in html
|
|
|
|
|
|
def test_profile_page_links_to_dashboard():
|
|
html = Path("app/static/profile.html").read_text(encoding="utf-8")
|
|
assert "/static/dashboard.html" in html
|
|
|
|
|
|
def test_visuals_page_reads_profile_and_goal_history():
|
|
"""Phase 5 visualizations read the profile and goal history via authedFetch."""
|
|
html = Path("app/static/visuals.html").read_text(encoding="utf-8")
|
|
assert "/discovery/profile/me" in html
|
|
assert "/discovery/profile/me/goal-history" in html
|
|
assert "authedFetch" in html
|
|
assert "user_id" not in html
|
|
|
|
|
|
def test_profile_page_links_to_visuals():
|
|
html = Path("app/static/profile.html").read_text(encoding="utf-8")
|
|
assert "/static/visuals.html" in html
|
|
|
|
|
|
def test_auth_helper_sends_credentials_and_refreshes():
|
|
js = Path("app/static/auth.js").read_text(encoding="utf-8")
|
|
|
|
assert 'credentials: "include"' in js
|
|
assert "/api/auth/refresh" in js
|
|
assert "/api/auth/login" in js
|